Fix: Ensure BridgeJS.Macros.swift is processed by SwiftToSkeleton
#556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using TypeScript declarations (
.d.tsfiles) withBridgeJS, the generatedBridgeJS.Macros.swiftfile containing@JSFunction,@JSClass,@JSGetter, and@JSSetterdeclarations was not being processed bySwiftToSkeleton.This meant that:
BridgeJS.jsonskeletonJavaScriptglue code was generated for these importsRoot Cause
The
BridgeJSCommandPluginfilters out files from the Generated/ directory when passing input files toBridgeJSTool:Since
BridgeJS.Macros.swiftis generated into theGenerated/directory, it was never included in the list of files to process, even though it contains important type information thatSwiftToSkeletonneeds to build the imported skeleton.Solution
After generating
BridgeJS.Macros.swiftfromTypeScript definitions, explicitly add it to the inputFiles array before processing withSwiftToSkeleton